Henning Snater has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/123182

Change subject: Fixed tabbing to valueView's input from property input
......................................................................

Fixed tabbing to valueView's input from property input

Since the Variation's draw() has been converted to asynchronous operation, the 
focus can only
be moved after being notified about draw() having finished.

Change-Id: I099e7e4afe479588caca91971f2b564d6accb776
---
M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/82/123182/1

diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js 
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
index 2decdd8..c19ca79 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js
@@ -233,7 +233,9 @@
                                // the property might not be valid anymore 
aborting the rendering of the value
                                // view.
                                if( self._tabToValueView && self._variation ) {
-                                       self._variation.focus();
+                                       $( self._variation ).one( 'afterdraw', 
function() {
+                                               self._variation.focus();
+                                       } );
                                }
                        } );
                } );

-- 
To view, visit https://gerrit.wikimedia.org/r/123182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I099e7e4afe479588caca91971f2b564d6accb776
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to