jenkins-bot has submitted this change and it was merged.

Change subject: Replace preg_replace by preg_replace_callback
......................................................................


Replace preg_replace by preg_replace_callback

preg_replace() with /e is depreceated. Used in FlatPhpFFS
Replaced with preg_replace_callback()

Bug: 63183
Change-Id: I526e0264386a789991c3be531da16e740750664b
---
M ffs/FlatPhpFFS.php
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Nikerabbit: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/ffs/FlatPhpFFS.php b/ffs/FlatPhpFFS.php
index ed6af01..55a49e7 100644
--- a/ffs/FlatPhpFFS.php
+++ b/ffs/FlatPhpFFS.php
@@ -40,7 +40,12 @@
 
                foreach ( $matches as $_ ) {
                        $legal = Title::legalChars();
-                       $key = preg_replace( "/([^$legal]|\\\\)/ue", '\'\x\'.' 
. "dechex(ord('\\0'))", $_[1] );
+                       $key = preg_replace_callback( "/([^$legal]|\\\\)/u",
+                               function( $m ) {
+                                       return '\x' . dechex( ord( $m[0] ) );
+                               },
+                               $_[1]
+                       );
                        $value = str_replace( array( "\'", "\\\\" ), array( 
"'", "\\" ), $_[2] );
                        $messages[$key] = $value;
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/122330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I526e0264386a789991c3be531da16e740750664b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Kunalgrover05 <kunalgrove...@gmail.com>
Gerrit-Reviewer: BPositive <pr4tiklah...@gmail.com>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: SPQRobin <robinp.1...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to