[MediaWiki-commits] [Gerrit] Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit - change (VisualEditor/VisualEditor)

[Catrope (Code Review)]

Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/123891

Change subject: Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit
......................................................................

Clean up ve.dm.SurfaceFragment#isolateAndUnwrap a bit

* Move tx variable into inner function
* Merge startOffsetChange and endOffsetChange into adjustment

Change-Id: I0f684ed11f89c067c9a20cd2c4eaf6b4aa50b8c7
---
M modules/ve/dm/ve.dm.SurfaceFragment.js
1 file changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/91/123891/1

diff --git a/modules/ve/dm/ve.dm.SurfaceFragment.js 
b/modules/ve/dm/ve.dm.SurfaceFragment.js
index 6047326..120f812 100644
--- a/modules/ve/dm/ve.dm.SurfaceFragment.js
+++ b/modules/ve/dm/ve.dm.SurfaceFragment.js
@@ -830,7 +830,7 @@
        if ( !this.surface ) {
                return this;
        }
-       var nodes, startSplitNode, endSplitNode, tx,
+       var nodes, startSplitNode, endSplitNode,
                startOffset, endOffset,
                outerDepth = 0,
                factory = ve.dm.nodeFactory,
@@ -842,23 +842,22 @@
                fragment = this;
 
        function createSplits( splitNodes, insertBefore ) {
-               var i, length,
-                       startOffsetChange = 0, endOffsetChange = 0, data = [];
+               var i, length, tx,
+                       adjustment = 0, data = [];
                for ( i = 0, length = splitNodes.length; i < length; i++ ) {
                        data.unshift( { 'type': '/' + splitNodes[i].type } );
                        data.push( splitNodes[i].getClonedElement() );
 
                        if ( insertBefore ) {
-                               startOffsetChange += 2;
-                               endOffsetChange += 2;
+                               adjustment += 2;
                        }
                }
 
                tx = ve.dm.Transaction.newFromInsertion( 
fragment.getDocument(), insertBefore ? startOffset : endOffset, data );
                fragment.surface.change( tx, !fragment.noAutoSelect && 
tx.translateRange( fragment.getRange() ) );
 
-               startOffset += startOffsetChange;
-               endOffset += endOffsetChange;
+               startOffset += adjustment;
+               endOffset += adjustment;
        }
 
        nodes = this.getDocument().selectNodes( this.getRange(), 'siblings' );

-- 
To view, visit https://gerrit.wikimedia.org/r/123891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f684ed11f89c067c9a20cd2c4eaf6b4aa50b8c7
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits