Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/124061
Change subject: RTL positioning for compact interlanguage links
......................................................................
RTL positioning for compact interlanguage links
Bug: 62981
Change-Id: If68975431eb58a7fcafcb7fec9f8a95f5e09ad80
---
M resources/js/ext.uls.compactlinks.js
1 file changed, 14 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/61/124061/1
diff --git a/resources/js/ext.uls.compactlinks.js
b/resources/js/ext.uls.compactlinks.js
index 439faa6..25f2dee 100644
--- a/resources/js/ext.uls.compactlinks.js
+++ b/resources/js/ext.uls.compactlinks.js
@@ -90,9 +90,7 @@
*/
listen: function () {
var languages,
- ulsTop, ulsLeft,
compactLinks = this,
- triggerPosition =
compactLinks.$trigger.offset(),
ulsLanguageList = {};
languages = $.map( compactLinks.interlanguageList,
function ( language, languageCode ) {
@@ -100,9 +98,6 @@
return languageCode;
} );
-
- ulsTop = triggerPosition.top -
compactLinks.$trigger.height() / 2 - 250 + 'px';
- ulsLeft = triggerPosition.left +
compactLinks.$trigger.width() + compactLinks.$interlanguageList.width() + 'px';
// Attach ULS to the trigger
compactLinks.$trigger.uls( {
@@ -121,13 +116,24 @@
mw.uls.setPreviousLanguages(
previousLanguages );
window.location.href =
compactLinks.interlanguageList[ language ].href;
},
+ onVisible: function () {
+ var interlanguageListLeft =
compactLinks.$interlanguageList.offset().left;
+
+ // Calculate the positioning of the
panel
+ // according to the position of the
trigger icon
+ if ( $( 'html' ).prop( 'dir' ) ===
'rtl' ) {
+ this.left =
interlanguageListLeft - this.$menu.width();
+ } else {
+ this.left =
interlanguageListLeft + compactLinks.$interlanguageList.width();
+ }
+
+ this.$menu.css( 'left', this.left );
+ },
// Use compact version of ULS
compact: true,
- // Left position of the language selector
- left: ulsLeft,
// Top position of the language selector. Top
it 250px above to take care of
// caret pointing the trigger. See
.interlanguage-uls-menu:after style definition
- top: ulsTop,
+ top: compactLinks.$trigger.offset().top -
compactLinks.$trigger.height() / 2 - 250,
// List of languages to be shown
languages: ulsLanguageList,
// Show common languages
--
To view, visit https://gerrit.wikimedia.org/r/124061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If68975431eb58a7fcafcb7fec9f8a95f5e09ad80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
