TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/124338

Change subject: Toolbar: use CSS instead of valign on toolbar table
......................................................................

Toolbar: use CSS instead of valign on toolbar table

Bug: 39726
Change-Id: I31f1e685052f8f9eef9061564a75fd022c95281a
---
M modules/jquery.wikiEditor.toolbar.css
M modules/jquery.wikiEditor.toolbar.js
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/38/124338/1

diff --git a/modules/jquery.wikiEditor.toolbar.css 
b/modules/jquery.wikiEditor.toolbar.css
index 3551bca..1791d34 100644
--- a/modules/jquery.wikiEditor.toolbar.css
+++ b/modules/jquery.wikiEditor.toolbar.css
@@ -239,6 +239,9 @@
        padding: 5px;
        margin: 0;
 }
+.wikiEditor-ui-toolbar .section-help .page-table .cell {
+       vertical-align: top;
+}
 .wikiEditor-ui-toolbar .section-help .page-table td.cell-syntax,
 .wikiEditor-ui-toolbar .section-help .page-table td.syntax {
        font-family: monospace, "Courier New";
diff --git a/modules/jquery.wikiEditor.toolbar.js 
b/modules/jquery.wikiEditor.toolbar.js
index 26e1a88..936c2bf 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -517,7 +517,7 @@
        buildRow : function( context, row ) {
                var html = '<tr>';
                for ( var cell in row ) {
-                       html += '<td class="cell cell-' + cell + '" 
valign="top"><span>' +
+                       html += '<td class="cell cell-' + cell + '"><span>' +
                                $.wikiEditor.autoMsg( row[cell], ['html', 
'text'] ) + '</span></td>';
                }
                return html + '</tr>';

-- 
To view, visit https://gerrit.wikimedia.org/r/124338
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31f1e685052f8f9eef9061564a75fd022c95281a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to