Brion VIBBER has submitted this change and it was merged.
Change subject: Fix margin for saved pages / history icons in RTL languages
......................................................................
Fix margin for saved pages / history icons in RTL languages
Change-Id: Ida5f323123f75505db676b756c88ce8f84d8adb0
---
M wikipedia/res/layout/item_history_entry.xml
M wikipedia/res/layout/item_saved_page_entry.xml
2 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
Brion VIBBER: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/res/layout/item_history_entry.xml
b/wikipedia/res/layout/item_history_entry.xml
index 3bab9c0..b24a05b 100644
--- a/wikipedia/res/layout/item_history_entry.xml
+++ b/wikipedia/res/layout/item_history_entry.xml
@@ -20,15 +20,13 @@
android:id="@+id/history_source"
android:layout_gravity="center_vertical"
android:layout_marginLeft="8dp"
+ android:layout_marginStart="8dp"
/>
<ImageView
android:id="@+id/history_thumbnail"
android:layout_height="32dp"
android:layout_width="32dp"
- android:layout_marginLeft="8dp"
- android:layout_marginRight="8dp"
- android:layout_marginTop="8dp"
- android:layout_marginBottom="8dp"
+ android:layout_margin="8dp"
android:layout_gravity="center_vertical"
android:background="@android:color/transparent"
/>
diff --git a/wikipedia/res/layout/item_saved_page_entry.xml
b/wikipedia/res/layout/item_saved_page_entry.xml
index cf879ed..d13c1a8 100644
--- a/wikipedia/res/layout/item_saved_page_entry.xml
+++ b/wikipedia/res/layout/item_saved_page_entry.xml
@@ -21,15 +21,13 @@
android:id="@+id/saved_page_source"
android:layout_gravity="center_vertical"
android:layout_marginLeft="8dp"
+ android:layout_marginStart="8dp"
/>
<ImageView
android:id="@+id/saved_page_thumbnail"
android:layout_height="32dp"
android:layout_width="32dp"
- android:layout_marginLeft="8dp"
- android:layout_marginRight="8dp"
- android:layout_marginTop="8dp"
- android:layout_marginBottom="8dp"
+ android:layout_margin="8dp"
android:layout_gravity="center_vertical"
android:background="@android:color/transparent"
/>
--
To view, visit https://gerrit.wikimedia.org/r/124523
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida5f323123f75505db676b756c88ce8f84d8adb0
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
