Brion VIBBER has submitted this change and it was merged.

Change subject: Fix RTL issues with username display in drawer
......................................................................


Fix RTL issues with username display in drawer

Change-Id: I07a866421f57dfa0c80d20ff57bf016772af721e
---
M wikipedia/res/layout/fragment_navdrawer.xml
1 file changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Brion VIBBER: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/wikipedia/res/layout/fragment_navdrawer.xml 
b/wikipedia/res/layout/fragment_navdrawer.xml
index ab35118..29bfd8e 100644
--- a/wikipedia/res/layout/fragment_navdrawer.xml
+++ b/wikipedia/res/layout/fragment_navdrawer.xml
@@ -17,7 +17,6 @@
                       
android:background="?android:attr/selectableItemBackground"
                       android:paddingTop="8dp"
                       android:paddingBottom="8dp"
-                      android:paddingRight="8dp"
                 >
             <ImageView android:layout_width="24dp" android:layout_height="24dp"
                        android:layout_margin="12dp"
@@ -51,7 +50,6 @@
                       android:id="@+id/nav_item_username"
                       android:paddingTop="8dp"
                       android:paddingBottom="8dp"
-                      android:paddingRight="8dp"
                       android:visibility="gone"
                 >
             <ImageView android:layout_width="24dp" android:layout_height="24dp"
@@ -64,10 +62,9 @@
                           android:orientation="vertical"
                     >
                 <org.wikipedia.styledviews.StyledTextView
-                        android:layout_width="match_parent"
+                        android:layout_width="wrap_content"
                         android:layout_height="48dp"
                         android:gravity="center_vertical"
-                        android:layout_gravity="center_vertical"
                         android:id="@+id/nav_item_username_primary_text"
                         style="?android:textAppearanceMediumInverse"
                         />

-- 
To view, visit https://gerrit.wikimedia.org/r/124550
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07a866421f57dfa0c80d20ff57bf016772af721e
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to