Catrope has submitted this change and it was merged. Change subject: Really remove all, not just half ......................................................................
Really remove all, not just half Iterating forwards while removing from an array is a good way to get half way there and be confused as hell. Change-Id: I74db84eee87c73d8e035f6dc8a92be0d0b9b3dad --- M modules/ve/ve.OrderedHashSet.js 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Catrope: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25695 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I74db84eee87c73d8e035f6dc8a92be0d0b9b3dad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
