Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/125060

Change subject: Fix tipsy bug, part 2
......................................................................

Fix tipsy bug, part 2

Change-Id: Ie3bf54c1f5e550b86bf29151ed14be36ad63bee0
---
M resources/mmv/ui/mmv.ui.stripeButtons.js
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer 
refs/changes/60/125060/1

diff --git a/resources/mmv/ui/mmv.ui.stripeButtons.js 
b/resources/mmv/ui/mmv.ui.stripeButtons.js
index d2af403..d864a6a 100644
--- a/resources/mmv/ui/mmv.ui.stripeButtons.js
+++ b/resources/mmv/ui/mmv.ui.stripeButtons.js
@@ -345,11 +345,13 @@
                        buttons.$reuse.removeClass( 'open' );
                } );
 
-               this.readyToShowFeedbackTooltip = false;
-               this.setTimer( 'feedbackTooltip.show', function () {
-                       this.readyToShowFeedbackTooltip = true;
-                       this.maybeDisplayTooltip();
-               }, this.feedbackSettings.tooltipDelay * 1000 );
+               if ( this.shouldShowFeedbackSurvey() ) {
+                       this.readyToShowFeedbackTooltip = false;
+                       this.setTimer( 'feedbackTooltip.show', function () {
+                               this.readyToShowFeedbackTooltip = true;
+                               this.maybeDisplayTooltip();
+                       }, this.feedbackSettings.tooltipDelay * 1000 );
+               }
        };
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/125060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3bf54c1f5e550b86bf29151ed14be36ad63bee0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to