jenkins-bot has submitted this change and it was merged. Change subject: Workaround for OOJS ES3 incompatibility ......................................................................
Workaround for OOJS ES3 incompatibility Depends on I6cd13b4f3a72378eb27e3aaa313511ffb20227c3 Change-Id: Ia642bbd29d3cd239f1d4b56463a1d8efe4670793 --- M resources/mmv/ui/mmv.ui.reuse.dialog.js M resources/mmv/ui/mmv.ui.reuse.download.js M resources/mmv/ui/mmv.ui.reuse.embed.js M resources/mmv/ui/mmv.ui.reuse.share.js M resources/mmv/ui/mmv.ui.reuse.tab.js M resources/mmv/ui/mmv.ui.stripeButtons.js 6 files changed, 11 insertions(+), 11 deletions(-) Approvals: Gilles: Looks good to me, approved Aarcos: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/resources/mmv/ui/mmv.ui.reuse.dialog.js b/resources/mmv/ui/mmv.ui.reuse.dialog.js index deac92d..9d03bec 100644 --- a/resources/mmv/ui/mmv.ui.reuse.dialog.js +++ b/resources/mmv/ui/mmv.ui.reuse.dialog.js @@ -141,7 +141,7 @@ DP.unattach = function() { var tab; - this.constructor.super.prototype.unattach.call( this ); + this.constructor['super'].prototype.unattach.call( this ); this.stopListeningToOutsideClick(); this.reuseTabs.off( 'select' ); diff --git a/resources/mmv/ui/mmv.ui.reuse.download.js b/resources/mmv/ui/mmv.ui.reuse.download.js index 969a659..7c03fd1 100644 --- a/resources/mmv/ui/mmv.ui.reuse.download.js +++ b/resources/mmv/ui/mmv.ui.reuse.download.js @@ -28,7 +28,7 @@ * @param {jQuery} $container */ function Download( $container ) { - Download.super.call( this, $container ); + Download['super'].call( this, $container ); /** @property {mw.mmv.ui.reuse.Utils} utils - */ this.utils = new mw.mmv.ui.reuse.Utils(); @@ -130,7 +130,7 @@ * Clears listeners. */ DP.unattach = function () { - this.constructor.super.prototype.unattach.call( this ); + this.constructor['super'].prototype.unattach.call( this ); this.downloadSizeMenu.getMenu().off( 'select' ); this.$selectionArrow.off( 'click' ); diff --git a/resources/mmv/ui/mmv.ui.reuse.embed.js b/resources/mmv/ui/mmv.ui.reuse.embed.js index a2227c7..3e88d7b 100644 --- a/resources/mmv/ui/mmv.ui.reuse.embed.js +++ b/resources/mmv/ui/mmv.ui.reuse.embed.js @@ -29,7 +29,7 @@ * @param {jQuery} $container */ function Embed( $container ) { - Embed.super.call( this, $container ); + Embed['super'].call( this, $container ); /** * Formatter converting image data into formats needed for output @@ -223,7 +223,7 @@ * Clears listeners. */ EP.unattach = function() { - this.constructor.super.prototype.unattach.call( this ); + this.constructor['super'].prototype.unattach.call( this ); this.embedTextHtml.offDOMEvent( 'focus mousedown click' ); this.embedTextWikitext.offDOMEvent( 'focus mousedown click' ); @@ -363,7 +363,7 @@ * Shows the pane. */ EP.show = function () { - this.constructor.super.prototype.show.call( this ); + this.constructor['super'].prototype.show.call( this ); this.select(); }; diff --git a/resources/mmv/ui/mmv.ui.reuse.share.js b/resources/mmv/ui/mmv.ui.reuse.share.js index 69c4d3f..5e8e8b3 100644 --- a/resources/mmv/ui/mmv.ui.reuse.share.js +++ b/resources/mmv/ui/mmv.ui.reuse.share.js @@ -26,7 +26,7 @@ * @param {jQuery} $container */ function Share( $container ) { - Share.super.call( this, $container ); + Share['super'].call( this, $container ); this.init(); } @@ -66,7 +66,7 @@ * Shows the pane. */ SP.show = function () { - this.constructor.super.prototype.show.call( this ); + this.constructor['super'].prototype.show.call( this ); this.select(); }; @@ -107,7 +107,7 @@ * @inheritdoc */ SP.unattach = function() { - this.constructor.super.prototype.unattach.call( this ); + this.constructor['super'].prototype.unattach.call( this ); this.pageInput.offDOMEvent( 'focus mousedown click' ); }; diff --git a/resources/mmv/ui/mmv.ui.reuse.tab.js b/resources/mmv/ui/mmv.ui.reuse.tab.js index d5da9cb..3314309 100644 --- a/resources/mmv/ui/mmv.ui.reuse.tab.js +++ b/resources/mmv/ui/mmv.ui.reuse.tab.js @@ -26,7 +26,7 @@ * @constructor */ function Tab( $container ) { - Tab.super.call( this, $container ); + Tab['super'].call( this, $container ); /** * Container for the tab. diff --git a/resources/mmv/ui/mmv.ui.stripeButtons.js b/resources/mmv/ui/mmv.ui.stripeButtons.js index d898f0b..75ceb9e 100644 --- a/resources/mmv/ui/mmv.ui.stripeButtons.js +++ b/resources/mmv/ui/mmv.ui.stripeButtons.js @@ -259,7 +259,7 @@ * Clears listeners. */ SBP.unattach = function () { - this.constructor.super.prototype.unattach.call( this ); + this.constructor['super'].prototype.unattach.call( this ); this.buttons.$reuse.off( 'click.mmv-stripeButtons' ); }; -- To view, visit https://gerrit.wikimedia.org/r/124365 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia642bbd29d3cd239f1d4b56463a1d8efe4670793 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Aarcos <aarcos.w...@gmail.com> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits