jenkins-bot has submitted this change and it was merged.

Change subject: Rename option 'displayBadges' to 'badgeClassNames'
......................................................................


Rename option 'displayBadges' to 'badgeClassNames'

displayBadges sounds like it's a boolean setting. What this setting
really is is a list of ItemIds and (non-optional) CSS class names.

Badges that are not in this array stil get rendered as
class="badge-Q101", for example.

Change-Id: Ic16f0e885f1320331adfa76bc725566bee18e704
---
M client/config/WikibaseClient.default.php
M docs/options.wiki
2 files changed, 4 insertions(+), 7 deletions(-)

Approvals:
  Tobias Gritschacher: Looks good to me, approved
  WikidataJenkins: Verified
  Jeroen De Dauw: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/client/config/WikibaseClient.default.php 
b/client/config/WikibaseClient.default.php
index 754d4fa..47cd3d1 100644
--- a/client/config/WikibaseClient.default.php
+++ b/client/config/WikibaseClient.default.php
@@ -39,12 +39,9 @@
                'allowDataTransclusion' => true,
                'propagateChangesToRepo' => true,
                'otherProjectsLinks' => array(),
-               // array of badges that should be displayed
-               // If a sitelink has two or more badges listed here, we will 
use the one that
-               // comes first in the list. The array has to consist of item 
ids pointing to
-               // a class name, like array( 'Q123' => 
'wb-badge-featuredarticle' ) Supported
-               // names are currently "wb-badge-goodarticle" and 
"wb-badge-featuredarticle".
-               'displayBadges' => array(),
+               // List of additional CSS class names for site links that have 
badges, e.g.
+               // array( 'Q101' => 'wb-badge-featuredarticle' ).
+               'badgeClassNames' => array(),
 
                /**
                 * @todo this is a bit wikimedia-specific and need to find a 
better place for this stuff,
diff --git a/docs/options.wiki b/docs/options.wiki
index 83098cb..4d14689 100644
--- a/docs/options.wiki
+++ b/docs/options.wiki
@@ -95,7 +95,7 @@
 ;allowDataTransclusion: switch to enable data transclusion features like the 
<nowiki>{{#property}}</nowiki> parser function and the <tt>wikibase</tt> 
Scribunto module. Defaults to <tt>true</tt>.
 ;propagateChangesToRepo: switch to enable or disable the propagation of client 
changes to the repo. Defaults to <tt>true</tt>.
 ;languageLinkSiteGroup: the ID of the site group to be shown as language 
links. Defaults to <tt>null</tt>, which means the site's own site group.
-;displayBadges: a list of badges that should be displayed. If a sitelink has 
two or more badges listed here, we will use the one that comes first in the 
list. The array has to consist of item ids pointing to a class name, like 
<code>array( 'Q123' => 'wb-badge-featuredarticle' )</code>. Supported names are 
currently "wb-badge-goodarticle" and "wb-badge-featuredarticle".
+;badgeClassNames: A list of additional CSS class names for site links that 
have badges. The array has to consist of item ids pointing to a class name, 
like <code>array( 'Q101' => 'wb-badge-featuredarticle' )</code>. Class names 
that are supported by default are currently "wb-badge-goodarticle" and 
"wb-badge-featuredarticle".
 
 === Expert Settings ===
 ;injectRecentChanges: whether changes on the repository should be injected 
into this wiki's recent changes table, so they show up on watchlists, etc. 
Requires the <code>dispatchChanges.php</code> script to run, and this wiki to 
be listed in the <code>localClientDatabases</code> setting on the repository.

-- 
To view, visit https://gerrit.wikimedia.org/r/124650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic16f0e885f1320331adfa76bc725566bee18e704
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Bene <benestar.wikime...@googlemail.com>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to