jenkins-bot has submitted this change and it was merged.
Change subject: Fix typo in ve.dm.Scalable
......................................................................
Fix typo in ve.dm.Scalable
this.dimensions should actually be this.defaultDimensions.
Change-Id: I4c4e71c936c989c5f8d78940316112ad8188ba1b
---
M modules/ve/dm/ve.dm.Scalable.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/ve.dm.Scalable.js b/modules/ve/dm/ve.dm.Scalable.js
index ca4b145..6274b4a 100644
--- a/modules/ve/dm/ve.dm.Scalable.js
+++ b/modules/ve/dm/ve.dm.Scalable.js
@@ -144,7 +144,7 @@
* @fires defaultSizeChange
*/
ve.dm.Scalable.prototype.setDefaultDimensions = function ( dimensions ) {
- if ( !this.dimensions || !ve.compare( this.dimensions, dimensions ) ) {
+ if ( !this.defaultDimensions || !ve.compare( this.defaultDimensions,
dimensions ) ) {
this.defaultDimensions = ve.copy( dimensions );
this.valid = null;
this.emit( 'defaultSizeChange', this.isDefault() );
--
To view, visit https://gerrit.wikimedia.org/r/125522
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c4e71c936c989c5f8d78940316112ad8188ba1b
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
