jenkins-bot has submitted this change and it was merged.
Change subject: Make sure all switches have a default case
......................................................................
Make sure all switches have a default case
Bug: 63742
Change-Id: Ic98b13055222d54c3e988688483c8d55acfc0067
---
M wikipedia/src/main/java/org/wikipedia/ObservableWebView.java
M wikipedia/src/main/java/org/wikipedia/ParcelableLruCache.java
M wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.java
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
M
wikipedia/src/main/java/org/wikipedia/pagehistory/usercontributions/UserContribsActivity.java
5 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Brion VIBBER: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/src/main/java/org/wikipedia/ObservableWebView.java
b/wikipedia/src/main/java/org/wikipedia/ObservableWebView.java
index 5caedee..b64804f 100644
--- a/wikipedia/src/main/java/org/wikipedia/ObservableWebView.java
+++ b/wikipedia/src/main/java/org/wikipedia/ObservableWebView.java
@@ -81,6 +81,9 @@
case MotionEvent.ACTION_CANCEL:
onUpOrCancelMotionEventListener.onUpOrCancelMotionEvent();
break;
+ default:
+ // Do nothing for all the other things
+ break;
}
}
return super.onTouchEvent(event);
diff --git a/wikipedia/src/main/java/org/wikipedia/ParcelableLruCache.java
b/wikipedia/src/main/java/org/wikipedia/ParcelableLruCache.java
index 1e1f465..5c4e3be 100644
--- a/wikipedia/src/main/java/org/wikipedia/ParcelableLruCache.java
+++ b/wikipedia/src/main/java/org/wikipedia/ParcelableLruCache.java
@@ -50,6 +50,8 @@
case TYPE_STRING:
put(key, (V) contents.getString(key));
break;
+ default:
+ throw new RuntimeException("Unknown key type encountered "
+ type);
}
}
}
@@ -76,6 +78,8 @@
case TYPE_STRING:
bundle.putString(entry.getKey(), (String)
entry.getValue());
break;
+ default:
+ throw new RuntimeException("Unknown key type encountered "
+ type);
}
}
dest.writeBundle(bundle);
diff --git
a/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.java
b/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.java
index 28c04d8..d74d596 100644
---
a/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.java
+++
b/wikipedia/src/main/java/org/wikipedia/createaccount/CreateAccountActivity.java
@@ -194,7 +194,8 @@
case R.id.menu_create_account:
validator.validate();
return true;
+ default:
+ return super.onOptionsItemSelected(item);
}
- return super.onOptionsItemSelected(item);
}
}
\ No newline at end of file
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index 2cdd6f3..1dbb5da 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -221,6 +221,9 @@
populateNonLeadSections(page);
webView.scrollTo(0, scrollY);
break;
+ default:
+ // This should never happen
+ throw new RuntimeException("Unknown state encountered " +
state);
}
}
diff --git
a/wikipedia/src/main/java/org/wikipedia/pagehistory/usercontributions/UserContribsActivity.java
b/wikipedia/src/main/java/org/wikipedia/pagehistory/usercontributions/UserContribsActivity.java
index c8bad3b..1795f35 100644
---
a/wikipedia/src/main/java/org/wikipedia/pagehistory/usercontributions/UserContribsActivity.java
+++
b/wikipedia/src/main/java/org/wikipedia/pagehistory/usercontributions/UserContribsActivity.java
@@ -93,9 +93,9 @@
case android.R.id.home:
finish();
return true;
+ default:
+ return super.onOptionsItemSelected(item);
}
-
- return false;
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/126116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic98b13055222d54c3e988688483c8d55acfc0067
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
