Brion VIBBER has submitted this change and it was merged.
Change subject: Mark some uninheritable classes as final
......................................................................
Mark some uninheritable classes as final
Bug: 63742
Change-Id: I467f04b9a08386fff8e5522ccc4e7ee62f32c4c8
---
M wikipedia/src/main/java/org/wikipedia/interlanguage/LangLinksActivity.java
M wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
M wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
M wikipedia/src/main/java/org/wikipedia/settings/LanguagePreference.java
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Brion VIBBER: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/interlanguage/LangLinksActivity.java
b/wikipedia/src/main/java/org/wikipedia/interlanguage/LangLinksActivity.java
index d2f4473..6b09f7e 100644
--- a/wikipedia/src/main/java/org/wikipedia/interlanguage/LangLinksActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/interlanguage/LangLinksActivity.java
@@ -162,7 +162,7 @@
}
}
- private static class LangLinksAdapter extends BaseAdapter {
+ private static final class LangLinksAdapter extends BaseAdapter {
private final ArrayList<PageTitle> origLangLinks;
private final ArrayList<PageTitle> langLinks;
private final WikipediaApp app;
diff --git a/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
b/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
index 9f0df84..eb4ec10 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/ToCHandler.java
@@ -114,7 +114,7 @@
return slidingPane.isOpen();
}
- private static class ToCAdapter extends BaseAdapter {
+ private static final class ToCAdapter extends BaseAdapter {
private final ArrayList<Section> sections;
private final PageTitle title;
diff --git
a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
index 2f18077..cd2b1d8 100644
--- a/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/search/SearchArticlesFragment.java
@@ -297,7 +297,7 @@
outState.putBoolean("pausedStateOfZero", pausedStateOfZero);
}
- private class SearchResultAdapter extends BaseAdapter {
+ private final class SearchResultAdapter extends BaseAdapter {
private List<PageTitle> results;
private final LayoutInflater inflater;
diff --git
a/wikipedia/src/main/java/org/wikipedia/settings/LanguagePreference.java
b/wikipedia/src/main/java/org/wikipedia/settings/LanguagePreference.java
index c21c278..20f90b6 100644
--- a/wikipedia/src/main/java/org/wikipedia/settings/LanguagePreference.java
+++ b/wikipedia/src/main/java/org/wikipedia/settings/LanguagePreference.java
@@ -72,7 +72,7 @@
return locale.getDisplayLanguage(locale);
}
- private static class LanguagesAdapter extends BaseAdapter {
+ private static final class LanguagesAdapter extends BaseAdapter {
private final String[] originalLanguages;
private final ArrayList<String> languages;
private final WikipediaApp app;
--
To view, visit https://gerrit.wikimedia.org/r/126129
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I467f04b9a08386fff8e5522ccc4e7ee62f32c4c8
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dr0ptp4kt <ab...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
