Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/126217
Change subject: Don't show "expand view" when Media Viewer is disabled ...................................................................... Don't show "expand view" when Media Viewer is disabled Change-Id: I52d9f044a2535ad9bc4f68b44ffc67058757bce8 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/456 --- M resources/mmv/mmv.bootstrap.js 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/17/126217/1 diff --git a/resources/mmv/mmv.bootstrap.js b/resources/mmv/mmv.bootstrap.js index 3722b8e..505154a 100755 --- a/resources/mmv/mmv.bootstrap.js +++ b/resources/mmv/mmv.bootstrap.js @@ -162,8 +162,8 @@ caption = this.htmlUtils.htmlToTextWithLinks( $thumbCaption.html() || '' ); } - if ( $thumb.closest( '#file' ).length > 0 ) { - // This is a file page. Make adjustments. + // This is a file page. Make adjustments, but only if media viewer links are activated for that user + if ( $thumb.closest( '#file' ).length > 0 && mw.config.get( 'wgMediaViewerOnClick' ) ) { link = $thumb.closest( 'a' ).prop( 'href' ); $( '<p>' ) -- To view, visit https://gerrit.wikimedia.org/r/126217 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52d9f044a2535ad9bc4f68b44ffc67058757bce8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
