Brion VIBBER has submitted this change and it was merged. Change subject: Fix broken tests for Page properties ......................................................................
Fix broken tests for Page properties Change-Id: I2ac7f3e3c6912cbf4e89f90289755a473b09bf44 --- M wikipedia-it/src/main/java/org/wikipedia/test/PageTests.java M wikipedia-it/src/main/java/org/wikipedia/test/ParcelableTest.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Brion VIBBER: Looks good to me, approved jenkins-bot: Verified diff --git a/wikipedia-it/src/main/java/org/wikipedia/test/PageTests.java b/wikipedia-it/src/main/java/org/wikipedia/test/PageTests.java index 9b9d4d2..5bea839 100644 --- a/wikipedia-it/src/main/java/org/wikipedia/test/PageTests.java +++ b/wikipedia-it/src/main/java/org/wikipedia/test/PageTests.java @@ -16,7 +16,7 @@ sections.add(new Section(i, 1, "Something " + i, "Something_" + i, "Content Something" + i)); } PageTitle title = new PageTitle(null, "Test", new Site("en.wikipedia.org")); - PageProperties props = new PageProperties(new Date()); + PageProperties props = new PageProperties(new Date(), "null"); Page page = new Page(title, sections, props); assertEquals(page, new Page(page.toJSON())); } diff --git a/wikipedia-it/src/main/java/org/wikipedia/test/ParcelableTest.java b/wikipedia-it/src/main/java/org/wikipedia/test/ParcelableTest.java index 49819b1..ca2f806 100644 --- a/wikipedia-it/src/main/java/org/wikipedia/test/ParcelableTest.java +++ b/wikipedia-it/src/main/java/org/wikipedia/test/ParcelableTest.java @@ -44,7 +44,7 @@ sections.add(new Section(i, 1, "Something " + i, "Something_" + i, "Content Something" + i)); } PageTitle title = new PageTitle(null, "Test", new Site("en.wikipedia.org")); - PageProperties props = new PageProperties(new Date()); + PageProperties props = new PageProperties(new Date(), "Something"); Page page = new Page(title, sections, props); parcelAndTestObjects(page); } -- To view, visit https://gerrit.wikimedia.org/r/126238 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ac7f3e3c6912cbf4e89f90289755a473b09bf44 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits