Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/126911
Change subject: Update VE core submodule for cherry-picks to make math inspector work ...................................................................... Update VE core submodule for cherry-picks to make math inspector work Use new dm.Surface method for checking undo history state (hasPastState -> hasBeenModified). New changes: 38776df [BREAKING CHANGE] Refactor history state methods to better suit uses 0c5238c Add system to dm.Surface for staging changes 8f0077c Only hide popups on selection change 1ff6c8d Create ve#contains 92be9e2 Prevent pasteTarget selection while already selected b3e5759 Make ve.dm.Surface#breakpoint not crash Change-Id: I5437e837f0b66a3094a7c1c43c91fcdd17b10783 --- M lib/ve M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/11/126911/1 diff --git a/lib/ve b/lib/ve index 74353d9..b3e5759 160000 --- a/lib/ve +++ b/lib/ve -Subproject commit 74353d93e9a5234aff63288028670e5dc38c72a3 +Subproject commit b3e5759654594dfcf8ee033df3f3fcb37fc3ecda diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js index 16248b6..31ed6a8 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js @@ -748,7 +748,7 @@ * Re-evaluate whether the toolbar save button should be disabled or not. */ ve.init.mw.ViewPageTarget.prototype.updateToolbarSaveButtonState = function () { - this.edited = this.surface.getModel().hasPastState(); + this.edited = this.surface.getModel().hasBeenModified(); // Disable the save button if we have no history or if the sanity check is not finished this.toolbarSaveButton.setDisabled( ( !this.edited && !this.restoring ) || !this.sanityCheckFinished ); this.toolbarSaveButton.$element.toggleClass( 've-init-mw-viewPageTarget-waiting', !this.sanityCheckFinished ); -- To view, visit https://gerrit.wikimedia.org/r/126911 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5437e837f0b66a3094a7c1c43c91fcdd17b10783 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: wmf/1.23wmf22 Gerrit-Owner: Catrope <roan.katt...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits