Adamw has submitted this change and it was merged. Change subject: Implement XMLDOM_Pugi ......................................................................
Implement XMLDOM_Pugi * Wrap pugixml pointers. Memory management semantics: The refcounted XMLDocument object owns the entire DOM's memory; Inputs are copied. Nodes cannot exist outside the DOM, and are freed implicitly. * Make sure to pass down makeflags to recursive makes, and spec dependencies in CMakelists.txt a bit tighter. This enables proper parallel make. * Fix a few warnings in the tokenizer TODO: * Improve XMLDocument functionality * Implement node move semantics: Need access to pugixml internals (xml_node_struct). Patchset 3: rebase Change-Id: I45f6d36bfc18d6e738c386c9dcbb4eb632da82a3 --- M cpp/Makefile M cpp/src/CMakeLists.txt M cpp/src/IntrusivePtrBase.hpp M cpp/src/LibIncludes.hpp M cpp/src/Parsoid.cpp M cpp/src/XMLDOM.hpp A cpp/src/XMLDOM_Pugi.cpp M cpp/src/XMLDOM_Pugi.hpp M cpp/src/wikitext_tokenizer.leg 9 files changed, 556 insertions(+), 46 deletions(-) Approvals: Adamw: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45f6d36bfc18d6e738c386c9dcbb4eb632da82a3 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: Adamw <[email protected]> Gerrit-Reviewer: GWicke <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
