Hashar has submitted this change and it was merged. Change subject: more public accessors for Title class ......................................................................
more public accessors for Title class This patch adds new public accessor to the Title class. They are merely returning the already existing conventions. Added tests for the four new methods: - Title::getBaseText() - Title::getRootText() - Title::getRootTitle() - Title::getSubpageText() The later does not test with $wgNamespacesWithSubpages variants. Change-Id: I4f7230c1a5487b82d06c78a45c50436085df57be --- M includes/Title.php M tests/phpunit/includes/TitleTest.php 2 files changed, 142 insertions(+), 3 deletions(-) Approvals: Hashar: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/20478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f7230c1a5487b82d06c78a45c50436085df57be Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Friesen <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: Parent5446 <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
