jenkins-bot has submitted this change and it was merged.
Change subject: Break ternary operations into multiple lines
......................................................................
Break ternary operations into multiple lines
Bug: 61267
Change-Id: I777c658de502c934abd72eea9e4bd72ceb956560
---
M resources/ext.popups.core.js
1 file changed, 12 insertions(+), 4 deletions(-)
Approvals:
Yuvipanda: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ext.popups.core.js b/resources/ext.popups.core.js
index 0ef2ca8..b1176f5 100644
--- a/resources/ext.popups.core.js
+++ b/resources/ext.popups.core.js
@@ -134,7 +134,9 @@
x: ( thumbnail.width >
SIZES.portraitImage.w ) ?
( (
thumbnail.width - SIZES.portraitImage.w ) / -2 ) :
(
SIZES.portraitImage.w - thumbnail.width ),
- y: ( thumbnail.height >
SIZES.portraitImage.h) ? ( ( thumbnail.height - SIZES.portraitImage.h ) / -2 )
: 0,
+ y: ( thumbnail.height >
SIZES.portraitImage.h) ?
+ ( (
thumbnail.height - SIZES.portraitImage.h ) / -2 ) :
+ 0,
width: thumbnail.width,
height: thumbnail.height
} );
@@ -161,7 +163,9 @@
'xlink:href':
thumbnail.source,
'clip-path':
'url(#mwe-popups-mask)',
x: 0,
- y: ( thumbnail.height >
SIZES.landscapeImage.h) ? ( ( thumbnail.height - SIZES.landscapeImage.h ) / -2
) : 0,
+ y: ( thumbnail.height >
SIZES.landscapeImage.h) ?
+ ( (
thumbnail.height - SIZES.landscapeImage.h ) / -2 ) :
+ 0,
width: thumbnail.width,
height: thumbnail.height
} );
@@ -169,9 +173,13 @@
$thumbnail = $( '<svg>' )
.attr( {
xmlns:
'http://www.w3.org/2000/svg',
- viewBox: '0 0 ' +
SIZES.landscapeImage.w + ' ' + ( thumbnail.height > SIZES.landscapeImage.h ) ?
SIZES.landscapeImage.h : thumbnail.height,
+ viewBox: '0 0 ' +
SIZES.landscapeImage.w + ' ' + ( thumbnail.height > SIZES.landscapeImage.h ) ?
+
SIZES.landscapeImage.h :
+
thumbnail.height,
width:
SIZES.landscapeImage.w + 3,
- height: (
thumbnail.height > SIZES.landscapeImage.h ) ? SIZES.landscapeImage.h :
thumbnail.height
+ height: (
thumbnail.height > SIZES.landscapeImage.h ) ?
+
SIZES.landscapeImage.h :
+ thumbnail.height
} )
.append( $thumbnail );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/124852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I777c658de502c934abd72eea9e4bd72ceb956560
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
