[MediaWiki-commits] [Gerrit] Fix Fatal error: Call to a member function doTransform() - change (mediawiki...TimedMediaHandler)

[Reedy (Code Review)]

Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/127619

Change subject: Fix Fatal error: Call to a member function doTransform()
......................................................................

Fix Fatal error: Call to a member function doTransform()

Bug: 64152
Change-Id: I7483c8b7ec75f5149998da2b530ca0467ac70de7
---
M TimedMediaThumbnail.php
1 file changed, 10 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/19/127619/1

diff --git a/TimedMediaThumbnail.php b/TimedMediaThumbnail.php
index 55f4290..7775744 100644
--- a/TimedMediaThumbnail.php
+++ b/TimedMediaThumbnail.php
@@ -198,8 +198,16 @@
                        "width" => $options['width'],
                        "height" => $options['height']
                );
-               $scaledThumb = $thumbFile->getHandler()->doTransform( 
$thumbFile,
-                       $options['dstPath'], $options['dstPath'], $thumbParams 
);
+               $handler = $thumbFile->getHandler();
+               if ( !$handler ) {
+                       return false;
+               }
+               $scaledThumb = $handler->doTransform(
+                       $thumbFile,
+                       $options['dstPath'],
+                       $options['dstPath'],
+                       $thumbParams
+               );
 
                if ( !$scaledThumb || $scaledThumb->isError() ) {
                        return $scaledThumb;

-- 
To view, visit https://gerrit.wikimedia.org/r/127619
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7483c8b7ec75f5149998da2b530ca0467ac70de7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: wmf/1.24wmf1
Gerrit-Owner: Reedy <re...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits