Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/127660

Change subject: Include pool type in pool counter log entries
......................................................................

Include pool type in pool counter log entries

Change-Id: I1b0213b5af755208843cb2cd02d3446c480f6882
---
M includes/poolcounter/PoolCounterWork.php
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/60/127660/1

diff --git a/includes/poolcounter/PoolCounterWork.php 
b/includes/poolcounter/PoolCounterWork.php
index 86bf8f1..523e9e0 100644
--- a/includes/poolcounter/PoolCounterWork.php
+++ b/includes/poolcounter/PoolCounterWork.php
@@ -25,13 +25,17 @@
  * Class for dealing with PoolCounters using class members
  */
 abstract class PoolCounterWork {
-       protected $cacheable = false; //Does this override getCachedWork() ?
+       /** @var string */
+       protected $type = 'generic';
+       /** @var bool */
+       protected $cacheable = false; // does this override getCachedWork() ?
 
        /**
         * @param string $type The type of PoolCounter to use
         * @param string $key Key that identifies the queue this work is placed 
on
         */
        public function __construct( $type, $key ) {
+               $this->type = $type;
                $this->poolCounter = PoolCounter::factory( $type, $key );
        }
 
@@ -75,7 +79,7 @@
        public function logError( $status ) {
                $key = $this->poolCounter->getKey();
 
-               wfDebugLog( 'poolcounter', "Pool key '$key': "
+               wfDebugLog( 'poolcounter', "Pool key '$key' ({$this->type}): "
                        . $status->getMessage()->inLanguage( 'en' 
)->useDatabase( false )->text() );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/127660
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b0213b5af755208843cb2cd02d3446c480f6882
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to