Dzahn has submitted this change and it was merged. Change subject: echoirc,wikistats,don't quote 'default' in switch ......................................................................
echoirc,wikistats,don't quote 'default' in switch ..or it becomes a WARNING: case statement without a default case Change-Id: I9a3f3df8dbddc11b888eb7c1e512dbb0ef2e0b4f --- M manifests/role/echoirc.pp M manifests/role/wikistats.pp 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/manifests/role/echoirc.pp b/manifests/role/echoirc.pp index 9c4ba2f..a82e768 100644 --- a/manifests/role/echoirc.pp +++ b/manifests/role/echoirc.pp @@ -14,7 +14,7 @@ $ircecho_nick = 'icinga-wm-labs' $ircecho_server = 'chat.freenode.net' } - 'default': { + default: { fail('unknown realm, please use labs or production') } } diff --git a/manifests/role/wikistats.pp b/manifests/role/wikistats.pp index 99327b5..9cf387d 100644 --- a/manifests/role/wikistats.pp +++ b/manifests/role/wikistats.pp @@ -14,7 +14,7 @@ 'production': { $wikistats_host = 'wikistats.wikimedia.org' } - 'default': { + default: { fail('unknown realm, should be labs or production') } } -- To view, visit https://gerrit.wikimedia.org/r/129670 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a3f3df8dbddc11b888eb7c1e512dbb0ef2e0b4f Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits