GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/129716

Change subject: Copy only a single copy of each path
......................................................................

Copy only a single copy of each path

Bug: https://github.com/gwicke/mathoid/issues/5
Change-Id: I96e529aed515bbe7ccff69347730ff3cfe958a36
---
M engine.js
1 file changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/16/129716/1

diff --git a/engine.js b/engine.js
index b1ffc3d..0dc39f2 100644
--- a/engine.js
+++ b/engine.js
@@ -80,12 +80,17 @@
 
     // clone and copy all used paths into local defs.
     // xlink:href in uses FIX
-    var uses = svg.getElementsByTagName("use");
+    var uses = svg.getElementsByTagName("use"),
+               // copy only one copy of each path
+               havePaths = {};
     for (var k = 0; k < uses.length; ++k) {
       var id = uses[k].getAttribute("href");
-      defs.appendChild(
-        document.getElementById(id.substr(1)).cloneNode(true)
-      );
+         if (!havePaths[id]) {
+                 defs.appendChild(
+                       document.getElementById(id.substr(1)).cloneNode(true)
+                 );
+                 havePaths[id] = true;
+         }
       uses[k].setAttribute("xlink:href", id);
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/129716
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96e529aed515bbe7ccff69347730ff3cfe958a36
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: GWicke <gwi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to