Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/130294
Change subject: Catch exceptions raise by localStorage write operations ...................................................................... Catch exceptions raise by localStorage write operations Change-Id: I3f062ff88c03ad3baca00461bff486a883776eb1 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/530 --- M resources/mmv/ui/mmv.ui.metadataPanel.js M resources/mmv/ui/mmv.ui.stripeButtons.js 2 files changed, 22 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/94/130294/1 diff --git a/resources/mmv/ui/mmv.ui.metadataPanel.js b/resources/mmv/ui/mmv.ui.metadataPanel.js index f1001a3..5ee27bf 100644 --- a/resources/mmv/ui/mmv.ui.metadataPanel.js +++ b/resources/mmv/ui/mmv.ui.metadataPanel.js @@ -830,7 +830,13 @@ scrolled && window.localStorage ) { - localStorage.setItem( 'mmv.hasOpenedMetadata', true ); + try { + localStorage.setItem( 'mmv.hasOpenedMetadata', true ); + } catch ( e ) { + // localStorage is full or disabled + } + + // We mark it as saved even when localStorage failed, because retrying will very likely fail as well this.savedHasOpenedMetadata = true; } }; diff --git a/resources/mmv/ui/mmv.ui.stripeButtons.js b/resources/mmv/ui/mmv.ui.stripeButtons.js index c4d460a..d26420e 100644 --- a/resources/mmv/ui/mmv.ui.stripeButtons.js +++ b/resources/mmv/ui/mmv.ui.stripeButtons.js @@ -138,7 +138,11 @@ this.tooltipDisplayCount = this.localStorage.getItem( 'mmv.tooltipDisplayCount' ); if ( this.tooltipDisplayCount === null ) { this.tooltipDisplayCount = 0; - this.localStorage.setItem( 'mmv.tooltipDisplayCount', 0 ); + try { + this.localStorage.setItem( 'mmv.tooltipDisplayCount', 0 ); + } catch ( e ) { + // localStorage is full or disabled + } } } return this.tooltipDisplayCount; @@ -151,7 +155,11 @@ this.getTooltipDisplayCount(); if ( this.tooltipDisplayCount !== undefined ) { this.tooltipDisplayCount++; - this.localStorage.setItem( 'mmv.tooltipDisplayCount', this.tooltipDisplayCount ); + try { + this.localStorage.setItem( 'mmv.tooltipDisplayCount', this.tooltipDisplayCount ); + } catch ( e ) { + // localStorage is full or disabled + } } }; @@ -163,7 +171,11 @@ this.getTooltipDisplayCount(); if ( this.tooltipDisplayCount !== undefined ) { this.tooltipDisplayCount = 999; - this.localStorage.setItem( 'mmv.tooltipDisplayCount', this.tooltipDisplayCount ); + try { + this.localStorage.setItem( 'mmv.tooltipDisplayCount', this.tooltipDisplayCount ); + } catch ( e ) { + // localStorage is full or disabled + } } }; -- To view, visit https://gerrit.wikimedia.org/r/130294 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f062ff88c03ad3baca00461bff486a883776eb1 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
