Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/130421
Change subject: Cleanup focus/select/clear
......................................................................
Cleanup focus/select/clear
Depends on I324dfc2 in OOUI
Change-Id: Id58d199c7ce3332a104ab2a5c395561ab94ae060
---
M lib/ve
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaInsertDialog.js
M modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
M modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/21/130421/1
diff --git a/lib/ve b/lib/ve
index d21c272..ed84663 160000
--- a/lib/ve
+++ b/lib/ve
-Subproject commit d21c272adfbba03a02f7242e02ceed2d3024a559
+Subproject commit ed846639a22319156526b1c92c8e93fe4a2bbdc3
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaInsertDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaInsertDialog.js
index 82c6ba4..399a1d8 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaInsertDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaInsertDialog.js
@@ -115,7 +115,7 @@
// Initialization
// This must be done only after there are proper
// sources defined
- this.search.getQuery().$input.focus().select();
+ this.search.getQuery().focus().select();
this.search.getResults().selectItem();
this.search.getResults().highlightItem();
}, this ) );
@@ -209,7 +209,7 @@
] ).collapseRangeToEnd().select();
}
- this.search.clear();
+ this.search.getQuery.setValue( '' );
// Parent method
ve.ui.Dialog.prototype.teardown.call( this, data );
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
index a0bc7b8..050d183 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
@@ -266,7 +266,7 @@
this.insertButton.$element.hide();
this.selectButton.$element.hide();
this.panels.setItem( this.searchPanel );
- this.search.getQuery().$input.focus().select();
+ this.search.getQuery().focus().select();
} } );
this.backButton.connect( this, { 'click': function () {
this.backButton.$element.hide();
@@ -354,7 +354,7 @@
this.referenceModel.updateInternalItem( surfaceModel );
}
- this.search.clear();
+ this.search.getQuery().setValue( '' );
this.referenceSurface.destroy();
this.referenceSurface = null;
this.referenceModel = null;
diff --git a/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
b/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
index fd22b0b..b6f31a6 100644
--- a/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
+++ b/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
@@ -111,7 +111,7 @@
ve.ui.Inspector.prototype.ready.call( this );
// Focus the input
- this.input.$input.focus().select();
+ this.input.focus().select();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/130421
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id58d199c7ce3332a104ab2a5c395561ab94ae060
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
