jenkins-bot has submitted this change and it was merged.
Change subject: Tweak fixed header behaviour
......................................................................
Tweak fixed header behaviour
Make it feel more responsive
Introduce small gap a la Winter mockup between left border
of search and top of screen
Change-Id: Id395257cd722a3363c7062bd1e10eee4f8e32805
---
M resources/fixedHeader/header.js
M resources/fixedHeader/header.less
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/fixedHeader/header.js b/resources/fixedHeader/header.js
index 9a4dd6e..49aa3ff 100644
--- a/resources/fixedHeader/header.js
+++ b/resources/fixedHeader/header.js
@@ -1,11 +1,11 @@
jQuery( function( $ ) {
- var $body = $( 'body' );
+ var $body = $( 'body' ), threshold = $( '#p-logo' ).height() - 10;
function goPositionFixed() {
- if ( $( this ).scrollTop() > 0 && !$( document.body ).hasClass(
'mw-special-MobileMenu' ) ) {
+ if ( $( this ).scrollTop() > threshold && !$body.hasClass(
'mw-special-MobileMenu' ) ) {
$body.addClass( 'mw-scrolled' );
} else {
$body.removeClass( 'mw-scrolled' );
}
}
- $( window ).on( 'scroll', $.debounce( 100, goPositionFixed ) );
+ $( window ).on( 'scroll', $.debounce( 0, goPositionFixed ) );
} );
diff --git a/resources/fixedHeader/header.less
b/resources/fixedHeader/header.less
index 52f7722..f3f0b22 100644
--- a/resources/fixedHeader/header.less
+++ b/resources/fixedHeader/header.less
@@ -60,7 +60,7 @@
background: none;
}
-#p-search,
+#p-search .searchButton,
div.vectorTabs,
div#content {
border-left: 1px solid @content-nav-divider-color;
@@ -73,7 +73,7 @@
}
div#simpleSearch {
- left: .35em;
+ left: 0;
background: none;
margin: 0;
border: none;
@@ -88,7 +88,7 @@
right: 0;
height: 100%;
padding: 0;
- top: 0;
+ top: .3em;
width: 50px;
// FIXME: Kill image tag when upstream to core.
--
To view, visit https://gerrit.wikimedia.org/r/121906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id395257cd722a3363c7062bd1e10eee4f8e32805
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/VectorBeta
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Jorm <bhar...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
