jenkins-bot has submitted this change and it was merged. Change subject: Change the tipsy gravity for the stripe buttons ......................................................................
Change the tipsy gravity for the stripe buttons - this avoids an issue where the arrow wouldn't point to what we want when near the edge of the screen - this avoids an RTL issue where the bubble would go outside of the screen Bug: 64258 Change-Id: I1cc9683af2743b093a45b19d7142fe7e5e66423f Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/485 --- M resources/mmv/ui/mmv.ui.stripeButtons.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: MarkTraceur: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mmv/ui/mmv.ui.stripeButtons.js b/resources/mmv/ui/mmv.ui.stripeButtons.js index 896402d..8234674 100644 --- a/resources/mmv/ui/mmv.ui.stripeButtons.js +++ b/resources/mmv/ui/mmv.ui.stripeButtons.js @@ -68,7 +68,7 @@ .prop( 'title', popupText ) // elements are right-floated so we use prepend instead of append to keep the order .prependTo( this.$buttonContainer ) - .tipsy( { gravity: 's' } ); + .tipsy( { gravity: $( document.body ).hasClass( 'rtl' ) ? 'sw' : 'se' } ); }; /** -- To view, visit https://gerrit.wikimedia.org/r/130604 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cc9683af2743b093a45b19d7142fe7e5e66423f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
