jenkins-bot has submitted this change and it was merged.
Change subject: Use window 'ready' event to focus surfaces
......................................................................
Use window 'ready' event to focus surfaces
Depends on I57864586b in OOUI.
Change-Id: Ic9a6e8d466c4d8b1273f54e621bb5a6cab50be53
---
M modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
M modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
index d23608c..6faf447 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWMediaEditDialog.js
@@ -25,7 +25,7 @@
this.scalable = null;
// Events
- this.connect( this, { 'open': 'onOpen' } );
+ this.connect( this, { 'ready': 'onReady' } );
};
/* Inheritance */
@@ -557,9 +557,9 @@
};
/**
- * Respond to 'open' event. Fires once the dialog has finished opening.
+ * Handle window ready events
*/
-ve.ui.MWMediaEditDialog.prototype.onOpen = function () {
+ve.ui.MWMediaEditDialog.prototype.onReady = function () {
// Focus the caption surface
this.captionSurface.focus();
};
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
index ffe3f0f..03960f0 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWReferenceDialog.js
@@ -22,7 +22,7 @@
this.referenceModel = null;
// Events
- this.connect( this, { 'open': 'onOpen' } );
+ this.connect( this, { 'ready': 'onReady' } );
};
/* Inheritance */
@@ -155,9 +155,9 @@
};
/**
- * Respond to 'open' event. Fires once the dialog has finished opening.
+ * Handle window ready events
*/
-ve.ui.MWReferenceDialog.prototype.onOpen = function () {
+ve.ui.MWReferenceDialog.prototype.onReady = function () {
// Focus the reference surface
this.referenceSurface.focus();
};
--
To view, visit https://gerrit.wikimedia.org/r/130251
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9a6e8d466c4d8b1273f54e621bb5a6cab50be53
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
