jenkins-bot has submitted this change and it was merged.
Change subject: Call clearAllMessages in setup instead of swapPanel on the save
dialog
......................................................................
Call clearAllMessages in setup instead of swapPanel on the save dialog
Was clearing things like captchas when swapping panels. It still makes
sense to clear these when opening up the dialog though.
Bug: 62766
Change-Id: I37ceeebc672e2866b805631b189108d8363bdc9f
---
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 14fda4a..f2c83ab 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -112,9 +112,6 @@
// Update the window title
this.setTitle( ve.msg( 'visualeditor-savedialog-title-' + panel ) );
- // Old messages should not persist after panel changes
- this.clearAllMessages();
-
// Reset save button if we disabled it for e.g. unrecoverable spam error
this.saveButton.setDisabled( false );
@@ -428,6 +425,9 @@
* @inheritdoc
*/
ve.ui.MWSaveDialog.prototype.setup = function () {
+ // Old messages should not persist after panel changes
+ this.clearAllMessages();
+
this.swapPanel( 'save' );
};
--
To view, visit https://gerrit.wikimedia.org/r/129830
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37ceeebc672e2866b805631b189108d8363bdc9f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
