jenkins-bot has submitted this change and it was merged.
Change subject: Consistent use the same IIFE style in javascript
......................................................................
Consistent use the same IIFE style in javascript
Most of our IIFE (Immediately-Invoced Function Expression) were
already the same way, these two were different. Made them
consistent (parenthesis on the outside).
$ ack '\}\s*\([^)]+\)\s*\)' --js resources/src/ skins/
81 matches (0 false positives)
$ ack '\}\s*\)\s*\(' --js resources/src/ skins/
6 matches (2 false positives, 2 in upstream forks)
Fixed the two matches in the last one that weren't upstream forks.
Change-Id: I51da0e7eb3c0a7071af0ebaa3310e31c99b9d3a5
---
M resources/src/mediawiki.page/mediawiki.page.gallery.js
M resources/src/mediawiki/mediawiki.util.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.page/mediawiki.page.gallery.js
b/resources/src/mediawiki.page/mediawiki.page.gallery.js
index 671cec6..e7c962f 100644
--- a/resources/src/mediawiki.page/mediawiki.page.gallery.js
+++ b/resources/src/mediawiki.page/mediawiki.page.gallery.js
@@ -247,7 +247,7 @@
}
}
}
- } )();
+ }() );
} );
} );
-} )( jQuery, mediaWiki );
+}( jQuery, mediaWiki ) );
diff --git a/resources/src/mediawiki/mediawiki.util.js
b/resources/src/mediawiki/mediawiki.util.js
index eb20d22..f09d03c 100644
--- a/resources/src/mediawiki/mediawiki.util.js
+++ b/resources/src/mediawiki/mediawiki.util.js
@@ -57,7 +57,7 @@
// Make sure we don't unset util.$content if it
was preset and we don't find anything
return util.$content;
- } )();
+ }() );
},
/* Main body */
--
To view, visit https://gerrit.wikimedia.org/r/130611
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51da0e7eb3c0a7071af0ebaa3310e31c99b9d3a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
