Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/130739

Change subject: ve.ce.Surface: Remove font-size: 1em;
......................................................................

ve.ce.Surface: Remove font-size: 1em;

In the MediaWiki integration we want the surface to look the same
as in read mode. For that, it we would apply the same class (e.g.
mw-body-content). However, that class assumes its font-size in em
size to be relative to #content. It doesn't have to be a direct
child of #content (the extra nestings Surface adds are fine), but
our contains between #content and surface must not change the
font-size as that will affect the font-size of the content.

Change-Id: Ibcee8e6ee8356fa6c2575dd6203c5d1e3ea78e63
---
M modules/ve/ce/styles/ve.ce.Surface.css
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/39/130739/1

diff --git a/modules/ve/ce/styles/ve.ce.Surface.css 
b/modules/ve/ce/styles/ve.ce.Surface.css
index 57efa01..855ef1e 100644
--- a/modules/ve/ce/styles/ve.ce.Surface.css
+++ b/modules/ve/ce/styles/ve.ce.Surface.css
@@ -7,7 +7,10 @@
 
 .ve-ce-surface {
        overflow: hidden;
-       font-size: 1em; /* to look more like MediaWiki use: 0.8em */;
+       /*
+       Remember, don't set font-size here.
+       Should be inherited from the VE target container.
+       */
 }
 
 .ve-ce-surface-textarea {

-- 
To view, visit https://gerrit.wikimedia.org/r/130739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibcee8e6ee8356fa6c2575dd6203c5d1e3ea78e63
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.24wmf2
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to