jenkins-bot has submitted this change and it was merged.
Change subject: Style external links and their suggestions with the right color
......................................................................
Style external links and their suggestions with the right color
Bug: 38726
Change-Id: I0f017bda9e5d4f8358db6656751fe1f13a7b845c
---
M modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
M modules/ve-mw/ui/themes/apex/ve.ui.MWLinkTargetInputWidget.css
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
b/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
index 3dcace7..ece550e 100644
--- a/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
+++ b/modules/ve-mw/ce/annotations/ve.ce.MWExternalLinkAnnotation.js
@@ -20,7 +20,7 @@
ve.ce.LinkAnnotation.call( this, model, parentNode, config );
// DOM changes
- this.$element.addClass( 've-ce-mwExternalLinkAnnotation' );
+ this.$element.addClass( 'external' );
// Put the href in the title
// Deliberately not using getResolvedAttribute() here
this.$element.attr( 'title', model.getAttribute( 'href' ) );
diff --git a/modules/ve-mw/ui/themes/apex/ve.ui.MWLinkTargetInputWidget.css
b/modules/ve-mw/ui/themes/apex/ve.ui.MWLinkTargetInputWidget.css
index 50b0e17..3023e46 100644
--- a/modules/ve-mw/ui/themes/apex/ve.ui.MWLinkTargetInputWidget.css
+++ b/modules/ve-mw/ui/themes/apex/ve.ui.MWLinkTargetInputWidget.css
@@ -19,10 +19,13 @@
color: #BA0000;
}
+.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=externalLink] {
+ color: #36b;
+}
+
.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=existingPage],
.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=matchingPage],
.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=disambigPage],
-.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=redirectPage],
-.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=externalLink] {
+.ve-ui-mwLinkTargetInputWidget-menu .oo-ui-menuItemWidget[rel=redirectPage] {
color: #0645AD;
}
--
To view, visit https://gerrit.wikimedia.org/r/130769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f017bda9e5d4f8358db6656751fe1f13a7b845c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
