jenkins-bot has submitted this change and it was merged.
Change subject: Lint elasticsearch/manifests/plugin.pp
......................................................................
Lint elasticsearch/manifests/plugin.pp
Enclose interpolated ${variables}. Makes puppet-lint happy.
Change-Id: I1a511da1c90cc143e89b80da79cb56af7c1c2590
---
M puppet/modules/elasticsearch/manifests/plugin.pp
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/puppet/modules/elasticsearch/manifests/plugin.pp
b/puppet/modules/elasticsearch/manifests/plugin.pp
index aab6b23..de99792 100644
--- a/puppet/modules/elasticsearch/manifests/plugin.pp
+++ b/puppet/modules/elasticsearch/manifests/plugin.pp
@@ -37,12 +37,12 @@
$url = undef,
) {
$esDir = '/usr/share/elasticsearch'
- $dirname = regsubst( $name, '^elasticsearch-', '' )
+ $dirname = regsubst($name, '^elasticsearch-', '')
$pluginDir = "${esDir}/plugins/${dirname}"
- $pluginIdentifier = "$group/${name}/${version}"
+ $pluginIdentifier = "${group}/${name}/${version}"
$urlParam = $url ? {
undef => '',
- default => "--url $url"
+ default => "--url ${url}"
}
case $ensure {
present: {
@@ -56,7 +56,7 @@
notify => Service['elasticsearch'],
}
exec { "Install elasticsearch plugin ${name}":
- command => "${esDir}/bin/plugin --install ${pluginIdentifier}
$urlParam",
+ command => "${esDir}/bin/plugin --install ${pluginIdentifier}
${urlParam}",
unless => "test -d ${pluginDir}",
require => [
Package['elasticsearch'],
--
To view, visit https://gerrit.wikimedia.org/r/130812
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a511da1c90cc143e89b80da79cb56af7c1c2590
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
