jenkins-bot has submitted this change and it was merged.
Change subject: Avoid Firefox errors in mw-ui.enhance
......................................................................
Avoid Firefox errors in mw-ui.enhance
I find onMwUiButtonBlur/Focus() are being called with an event.target of
document, and in that event event.target.className is undefined. But
it's not happening for other developers in Firefox.
Change-Id: I32eebf9fa631cd8a8d9a25928a67ce1f7c71d1bc
---
M modules/new/mw-ui.enhance.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
SG: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/new/mw-ui.enhance.js b/modules/new/mw-ui.enhance.js
index 53992ba..8cfdac3 100644
--- a/modules/new/mw-ui.enhance.js
+++ b/modules/new/mw-ui.enhance.js
@@ -81,8 +81,8 @@
document.attachEvent( 'focusin', onMwUiButtonFocus );
document.attachEvent( 'focusout', onMwUiButtonBlur );
} else {
- document.addEventListener( 'focus', onMwUiButtonFocus,
true );
- document.addEventListener( 'blur', onMwUiButtonBlur,
true );
+ document.body.addEventListener( 'focus',
onMwUiButtonFocus, true );
+ document.body.addEventListener( 'blur',
onMwUiButtonBlur, true );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/131006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32eebf9fa631cd8a8d9a25928a67ce1f7c71d1bc
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: frontend-rewrite
Gerrit-Owner: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: Bsitu <bs...@wikimedia.org>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: SG <shah...@gmail.com>
Gerrit-Reviewer: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
