jenkins-bot has submitted this change and it was merged.
Change subject: Don't error if module has no parameters
......................................................................
Don't error if module has no parameters
E.g. query prop=flowinfo gets actionInfo.parameters is undefined from
UiBuilder.js. This fixes the problem for me locally.
Change-Id: Idaad922635af8a5ffc6fda79e5109117114bc6d9
---
M resources/UiBuilder.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/UiBuilder.js b/resources/UiBuilder.js
index c88f359..0a79e8d 100644
--- a/resources/UiBuilder.js
+++ b/resources/UiBuilder.js
@@ -206,6 +206,9 @@
var params = '', i, length, param, name, $node, value,
prefix = this.prefix;
$.each( this.info, function ( action, actionInfo ) {
+ if ( !actionInfo.parameters ) {
+ return;
+ }
for ( i = 0, length =
actionInfo.parameters.length; i < length; i += 1 ) {
param = actionInfo.parameters[i];
name = prefix + actionInfo.prefix +
param.name;
--
To view, visit https://gerrit.wikimedia.org/r/131600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaad922635af8a5ffc6fda79e5109117114bc6d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ApiSandbox
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
