jenkins-bot has submitted this change and it was merged.
Change subject: [browser test] Links test to use API for target page
......................................................................
[browser test] Links test to use API for target page
Note that I reported Bug 64655 for Chrome but upon refactoring
this test I find the buggy behavior now in Firefox but Chrome
is fine. Browsers are weird, and the Links inspector is too.
Change-Id: Ibd90a33bb43342dc1d7410d621f01875e1c177bf
---
M modules/ve-mw/test/browser/features/links.feature
M modules/ve-mw/test/browser/features/step_definitions/links_steps.rb
2 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/test/browser/features/links.feature
b/modules/ve-mw/test/browser/features/links.feature
index f9a9265..9be13e3 100644
--- a/modules/ve-mw/test/browser/features/links.feature
+++ b/modules/ve-mw/test/browser/features/links.feature
@@ -1,8 +1,10 @@
-@edit_user_page @en.wikipedia.beta.wmflabs.org @firefox @login
@test2.wikipedia.org
+@en.wikipedia.beta.wmflabs.org @firefox @login @test2.wikipedia.org
Feature: VisualEditor Links
Background:
- Given I click the Link button
+ Given I go to the "Links VisualEditor Test" page with content "Links
VisualEditor Test"
+ And I make the text "Links VisualEditor Test" be selected
+ And I click the Link button
And I can see the Link User Inteface
Scenario: Enter external link
diff --git
a/modules/ve-mw/test/browser/features/step_definitions/links_steps.rb
b/modules/ve-mw/test/browser/features/step_definitions/links_steps.rb
index 4e52859..f846bdd 100644
--- a/modules/ve-mw/test/browser/features/step_definitions/links_steps.rb
+++ b/modules/ve-mw/test/browser/features/step_definitions/links_steps.rb
@@ -23,7 +23,7 @@
page.wait_until(10) do
page.links_diff_view.include? "example.com"
end
- page.links_diff_view.should match Regexp.escape("[http://www.example.com
Editing] ")
+ page.links_diff_view.should match Regexp.escape("[http://www.example.com
Links VisualEditor Test]")
end
end
@@ -36,7 +36,7 @@
page.wait_until(10) do
page.links_diff_view.include? "Main Page"
end
- page.links_diff_view.should match Regexp.escape("[[Main Page|Editing]]")
+ page.links_diff_view.should match Regexp.escape("[[Main Page|Links
VisualEditor Test]]")
end
end
@@ -49,7 +49,7 @@
page.wait_until(10) do
page.links_diff_view.include? "DoesNotExist"
end
- page.links_diff_view.should match Regexp.escape("[[DoesNotExist|Editing]]")
+ page.links_diff_view.should match Regexp.escape("[[DoesNotExist|Links
VisualEditor Test]]")
end
end
--
To view, visit https://gerrit.wikimedia.org/r/132015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd90a33bb43342dc1d7410d621f01875e1c177bf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
