jenkins-bot has submitted this change and it was merged.
Change subject: [browser test] Refactor Headings test to use the API
......................................................................
[browser test] Refactor Headings test to use the API
Re-enable this to run on Chrome also
Change-Id: Ia73778be44629a27a0ee4e3cde94f7fe2c2bf46e
---
M modules/ve-mw/test/browser/features/headings.feature
M modules/ve-mw/test/browser/features/step_definitions/shared_steps.rb
2 files changed, 14 insertions(+), 11 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/test/browser/features/headings.feature
b/modules/ve-mw/test/browser/features/headings.feature
index b780ffb..73286e6 100644
--- a/modules/ve-mw/test/browser/features/headings.feature
+++ b/modules/ve-mw/test/browser/features/headings.feature
@@ -1,5 +1,9 @@
-@edit_user_page @firefox @login
+@chrome @firefox @login
Feature: VisualEditor Headings
+
+ Background:
+ Given I go to the "Headings VisualEditor Test" page with content "Headings
VisualEditor Test"
+ And I make the text "Headings VisualEditor Test" be selected
Scenario Outline: Cycle through headings values
When I click the down arrow on Headings interface
@@ -9,12 +13,11 @@
Then <headings_string> should appear in the diff view
And I can click the X on the save box
Examples:
- | headings_interface_name | headings_string |
- | Paragraph | "^Editing" |
- | Heading | "^== Editing" |
- | Subheading1 | "^=== Editing" |
- | Subheading2 | "^==== Editing" |
- | Subheading3 | "^===== Editing" |
- | Subheading4 | "^====== Editing" |
- | Preformatted | " Editing" |
- | Page title | "^= Editing" |
+ | headings_interface_name | headings_string |
+ | Heading | "^== Headings VisualEditor Test" |
+ | Subheading1 | "^=== Headings VisualEditor Test" |
+ | Subheading2 | "^==== Headings VisualEditor Test" |
+ | Subheading3 | "^===== Headings VisualEditor Test" |
+ | Subheading4 | "^====== Headings VisualEditor Test" |
+ | Preformatted | " Headings VisualEditor Test" |
+ | Page title | "^= Headings VisualEditor Test" |
diff --git
a/modules/ve-mw/test/browser/features/step_definitions/shared_steps.rb
b/modules/ve-mw/test/browser/features/step_definitions/shared_steps.rb
index 82c4d8b..96456dc 100644
--- a/modules/ve-mw/test/browser/features/step_definitions/shared_steps.rb
+++ b/modules/ve-mw/test/browser/features/step_definitions/shared_steps.rb
@@ -68,7 +68,7 @@
end
When(/^I click Review your changes$/) do
- on(VisualEditorPage).review_changes_element.when_present.click
+ on(VisualEditorPage).review_changes_element.when_present(10).click
end
When(/^I edit the description of the change$/) do
--
To view, visit https://gerrit.wikimedia.org/r/132104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia73778be44629a27a0ee4e3cde94f7fe2c2bf46e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
