jenkins-bot has submitted this change and it was merged.
Change subject: Fix selector for linkitem init
......................................................................
Fix selector for linkitem init
The span either has wb-langlinks-edit if the page already is
connected to an item or wb-langlinks-add if it's not.
But the span never has wbc-editpage which is now being set on
the a within the span. If this anchor is being used, we will
have two nested links (only one visible though) with two pencils
next to them.
Bug: 65001
Change-Id: Iac189e7513fdb366aa418dac891f61b51a898354
---
M client/resources/wikibase.client.linkitem.init.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Aude: Looks good to me, approved
WikidataJenkins: Verified
jenkins-bot: Verified
diff --git a/client/resources/wikibase.client.linkitem.init.js
b/client/resources/wikibase.client.linkitem.init.js
index c8948a8..fe443a1 100644
--- a/client/resources/wikibase.client.linkitem.init.js
+++ b/client/resources/wikibase.client.linkitem.init.js
@@ -59,8 +59,7 @@
return;
}
- // @note .wbc-editpage is deprecated
- $( '.wbc-editpage, .wb-langlinks-add' ).eq( 0 )
+ $( '.wb-langlinks-edit, .wb-langlinks-add' ).eq( 0 )
.empty()
.append(
$( '<a>' )
--
To view, visit https://gerrit.wikimedia.org/r/132116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac189e7513fdb366aa418dac891f61b51a898354
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
