Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/132138
Change subject: Make LuaEngineTestBase compatible with phpunit 4.1
......................................................................
Make LuaEngineTestBase compatible with phpunit 4.1
PHPUnit_Framework_TestSuite::isPublicTestMethod has
been removed from phpunit 4.1.
Change-Id: I191b5f460fbef122d8e916c8f661f09083b33970
---
M tests/engines/LuaCommon/LuaEngineTestBase.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Scribunto
refs/changes/38/132138/1
diff --git a/tests/engines/LuaCommon/LuaEngineTestBase.php
b/tests/engines/LuaCommon/LuaEngineTestBase.php
index c9de00b..38f7b22 100644
--- a/tests/engines/LuaCommon/LuaEngineTestBase.php
+++ b/tests/engines/LuaCommon/LuaEngineTestBase.php
@@ -101,7 +101,7 @@
$engineSuite->setName( "$engineName: $className" );
foreach ( $class->getMethods() as $method ) {
- if (
PHPUnit_Framework_TestSuite::isPublicTestMethod( $method ) ) {
+ if ( PHPUnit_Framework_TestSuite::isTestMethod(
$method ) && $method->isPublic() ) {
$name = $method->getName();
$groups = PHPUnit_Util_Test::getGroups(
$className, $name );
$groups[] = 'Lua';
--
To view, visit https://gerrit.wikimedia.org/r/132138
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I191b5f460fbef122d8e916c8f661f09083b33970
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
