Jjanes has uploaded a new change for review.
https://gerrit.wikimedia.org/r/132586
Change subject: Fix watchlist query to work with PostgreSQL
......................................................................
Fix watchlist query to work with PostgreSQL
MySQL allows SQL to select a column which is not included in the
GROUP BY, and accomodates this by returning an arbitrary value
for that column from each group. PostgreSQL does not allow this
situation. Fix this by explicitly listing the columns to be
selected rather than using '.*' notation.
There is one other place in this extension where '.*' is used,
but that is not in a GROUP BY query and so should not cause
this type of problem.
Bug: 46745
Change-Id: I56caca2666be5eb94dac4a3d316a5bb140cb7b48
---
M includes/specials/SpecialMobileWatchlist.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/86/132586/1
diff --git a/includes/specials/SpecialMobileWatchlist.php
b/includes/specials/SpecialMobileWatchlist.php
index 3b57113..dd573f2 100644
--- a/includes/specials/SpecialMobileWatchlist.php
+++ b/includes/specials/SpecialMobileWatchlist.php
@@ -305,7 +305,7 @@
$conds['wl_user'] = $user->getId();
$tables = array( 'watchlist', 'page', 'revision' );
$fields = array(
- $dbr->tableName( 'watchlist' ) . '.*',
+ 'wl_namespace','wl_title',
// get the timestamp of the last change only
'MAX(' . $dbr->tableName( 'revision' ) .
'.rev_timestamp) AS rev_timestamp'
);
--
To view, visit https://gerrit.wikimedia.org/r/132586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I56caca2666be5eb94dac4a3d316a5bb140cb7b48
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jjanes <jeff.ja...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
