jenkins-bot has submitted this change and it was merged.

Change subject: No longer log creation of wikisets to WikiSet 0
......................................................................


No longer log creation of wikisets to WikiSet 0

Bug: 27031
Change-Id: I16ec70b98314005c41b2b10a5b59458351bdeaf7
---
M WikiSet.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WikiSet.php b/WikiSet.php
index 833ca73..785d641 100644
--- a/WikiSet.php
+++ b/WikiSet.php
@@ -186,6 +186,7 @@
         */
        public function commit() {
                $dbw = CentralAuthUser::getCentralDB();
+               $dbw->begin();
                $dbw->replace( 'wikiset', array( 'ws_id' ),
                        array(
                                'ws_id' => $this->mId,
@@ -194,10 +195,10 @@
                                'ws_wikis' => implode( ',', $this->mWikis ),
                        ), __METHOD__
                );
-               $dbw->commit();
                if ( !$this->mId ) {
                        $this->mId = $dbw->insertId();
                }
+               $dbw->commit();
                $this->purge();
                return (bool)$dbw->affectedRows();
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/130555
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I16ec70b98314005c41b2b10a5b59458351bdeaf7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: PiRSquared17 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to