Bartosz Dziewoński has uploaded a new change for review. https://gerrit.wikimedia.org/r/133185
Change subject: mediawiki.searchSuggest: Remove duplicate code ...................................................................... mediawiki.searchSuggest: Remove duplicate code The 'result' function for skin-provided search box is already provided above as "generic functionality", repeating it doesn't do anything. Change-Id: I8693f3dbbfb64ac2816da86759233e3870234d77 --- M resources/src/mediawiki/mediawiki.searchSuggest.js 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/85/133185/1 diff --git a/resources/src/mediawiki/mediawiki.searchSuggest.js b/resources/src/mediawiki/mediawiki.searchSuggest.js index 8a8871d..ea7c0c5 100644 --- a/resources/src/mediawiki/mediawiki.searchSuggest.js +++ b/resources/src/mediawiki/mediawiki.searchSuggest.js @@ -107,7 +107,7 @@ } } - // General suggestions functionality for all search boxes + // Generic suggestions functionality for all search boxes searchboxesSelectors = [ // Primary searchbox on every page in standard skins '#searchInput', @@ -168,12 +168,6 @@ // Special suggestions functionality for skin-provided search box $searchInput.suggestions( { - result: { - render: renderFunction, - select: function () { - return true; // allow the form to be submitted - } - }, special: { render: specialRenderFunction, select: function ( $input ) { -- To view, visit https://gerrit.wikimedia.org/r/133185 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8693f3dbbfb64ac2816da86759233e3870234d77 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits