AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/133198
Change subject: Fix a detail of TypesafeEnumTest
......................................................................
Fix a detail of TypesafeEnumTest
Removed a few lines from TypesafeEnumTest that are not pertinent for
testing the current implementation of TypesafeEnum.
Change-Id: I2ebb4f7f0195739743cfcac34af0759a3b239925
---
M tests/phpunit/TypesafeEnumTest.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Campaigns
refs/changes/98/133198/1
diff --git a/tests/phpunit/TypesafeEnumTest.php
b/tests/phpunit/TypesafeEnumTest.php
index d980538..ae51ae3 100644
--- a/tests/phpunit/TypesafeEnumTest.php
+++ b/tests/phpunit/TypesafeEnumTest.php
@@ -98,10 +98,6 @@
public function testIsDeclaredReturnsFalseWhenExpectedForString() {
$this->assertFalse( TestEnum::isDeclared( 'UNKNOWN_ENUM' ) );
-
- // Be sure this doesn't create a false positive, since it's
declared
- // as a static property, but is protected.
- $this->assertFalse( TestEnum::isDeclared( 'values' ) );
}
public function testGetValueByNameReturnsCorrectValue() {
--
To view, visit https://gerrit.wikimedia.org/r/133198
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ebb4f7f0195739743cfcac34af0759a3b239925
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Campaigns
Gerrit-Branch: wip/editorcampaigns
Gerrit-Owner: AndyRussG <andrew.green...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
