IAlex has uploaded a new change for review. https://gerrit.wikimedia.org/r/133209
Change subject: Remove unused variables from SpecialAllpages::showToplevel() ...................................................................... Remove unused variables from SpecialAllpages::showToplevel() Follow-up If750cad676 (71fe7c5) Change-Id: I95bf953b0eb742e94ddff1b6adf6d784fb5dc87c --- M includes/specials/SpecialAllpages.php 1 file changed, 0 insertions(+), 21 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/09/133209/1 diff --git a/includes/specials/SpecialAllpages.php b/includes/specials/SpecialAllpages.php index e4fc54b..ad92298 100644 --- a/includes/specials/SpecialAllpages.php +++ b/includes/specials/SpecialAllpages.php @@ -156,31 +156,10 @@ * @param bool $hideredirects Dont show redirects (default false) */ function showToplevel( $namespace = NS_MAIN, $from = '', $to = '', $hideredirects = false ) { - $output = $this->getOutput(); - - # TODO: Either make this *much* faster or cache the title index points - # in the querycache table. - - $dbr = wfGetDB( DB_SLAVE ); - $out = ""; - $where = array( 'page_namespace' => $namespace ); - - if ( $hideredirects ) { - $where['page_is_redirect'] = 0; - } - $from = Title::makeTitleSafe( $namespace, $from ); $to = Title::makeTitleSafe( $namespace, $to ); $from = ( $from && $from->isLocal() ) ? $from->getDBkey() : null; $to = ( $to && $to->isLocal() ) ? $to->getDBkey() : null; - - if ( isset( $from ) ) { - $where[] = 'page_title >= ' . $dbr->addQuotes( $from ); - } - - if ( isset( $to ) ) { - $where[] = 'page_title <= ' . $dbr->addQuotes( $to ); - } $this->showChunk( $namespace, $from, $to, $hideredirects ); } -- To view, visit https://gerrit.wikimedia.org/r/133209 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I95bf953b0eb742e94ddff1b6adf6d784fb5dc87c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex <coderev...@emsenhuber.ch> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits