Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/133263
Change subject: build: Simplify building of module dependency list
......................................................................
build: Simplify building of module dependency list
Change-Id: I598534c329178a182690a10009ac5c20718807df
---
M build/tasks/buildloader.js
1 file changed, 3 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/63/133263/1
diff --git a/build/tasks/buildloader.js b/build/tasks/buildloader.js
index 0a3196f..074e4b1 100644
--- a/build/tasks/buildloader.js
+++ b/build/tasks/buildloader.js
@@ -42,7 +42,7 @@
}
function buildDependencyList( modules, load, list ) {
- var i, j, k, module;
+ var i, module;
list = list || [];
@@ -59,15 +59,8 @@
}
// Append target load module to the end of the
current list
- list.push( module );
- }
-
- // We always want to retain the first entry of
duplicates
- for ( j = 0; j < list.length; j++ ) {
- for ( k = j + 1; k < list.length; k++ ) {
- if ( list[j] === list[k] ) {
- list.splice( k--, 1 );
- }
+ if ( list.indexOf( module ) === -1 ) {
+ list.push( module );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/133263
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I598534c329178a182690a10009ac5c20718807df
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
