jenkins-bot has submitted this change and it was merged.
Change subject: Load dependencies in correct order
......................................................................
Load dependencies in correct order
Pre-concating the dependencies loads them in reverse order.
Change-Id: I676137204c20e6833008ec028cc9773f5a33edf2
---
M build/tasks/buildloader.js
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/build/tasks/buildloader.js b/build/tasks/buildloader.js
index 33736d3..0a3196f 100644
--- a/build/tasks/buildloader.js
+++ b/build/tasks/buildloader.js
@@ -41,8 +41,10 @@
return true;
}
- function buildDependencyList( modules, load ) {
- var i, j, k, module, list = [];
+ function buildDependencyList( modules, load, list ) {
+ var i, j, k, module;
+
+ list = list || [];
for ( i = 0; i < load.length; i++ ) {
module = load[i];
@@ -53,8 +55,7 @@
// Add in any dependencies
if ( modules[module].hasOwnProperty(
'dependencies' ) ) {
- list = buildDependencyList( modules,
modules[module].dependencies )
- .concat( list );
+ buildDependencyList( modules,
modules[module].dependencies, list );
}
// Append target load module to the end of the
current list
--
To view, visit https://gerrit.wikimedia.org/r/133237
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I676137204c20e6833008ec028cc9773f5a33edf2
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
