Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/133271
Change subject: build: Remove jscs rule for "disallowRightStickedOperators"
......................................................................
build: Remove jscs rule for "disallowRightStickedOperators"
The disallowRightStickedOperators rule is obsolete with
requireSpace{Before,After}BinaryOperators and fixes a bug where
the following would be considered invalid when it shouldn't:
+!!constructor.static.matchFunction
// Operator + should not stick to following expression
This is a false positive due to the tricky nature of
disallowRightStickedOperators and for that reason this rule
has been deprecated and scheduled for removal in jscs 2.0.0
Change-Id: Ib731f11b1184d0e9865104a065421446a78dbfec
---
M .jscsrc
1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/core refs/changes/71/133271/1
diff --git a/.jscsrc b/.jscsrc
index eb2c768..bc49e03 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -44,22 +44,6 @@
"<="
],
"requireRightStickedOperators": ["!"],
- "disallowRightStickedOperators": [
- "?",
- "+",
- "/",
- "*",
- ":",
- "=",
- "==",
- "===",
- "!=",
- "!==",
- ">",
- ">=",
- "<",
- "<="
- ],
"requireLeftStickedOperators": [","],
"disallowSpaceAfterPrefixUnaryOperators": [
"++",
--
To view, visit https://gerrit.wikimedia.org/r/133271
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib731f11b1184d0e9865104a065421446a78dbfec
Gerrit-PatchSet: 1
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
