jenkins-bot has submitted this change and it was merged.
Change subject: build: Update jscs and jshint config
......................................................................
build: Update jscs and jshint config
jshint:
* Remove coding style option "curly" (already covered by jscs).
Follows-up 149bec2 which added jscs/requireCurlyBraces.
jscs:
* Remove rule for "disallowRightStickedOperators"
The disallowRightStickedOperators rule is obsolete with
requireSpace{Before,After}BinaryOperators and fixes a bug where
the following would be considered invalid when it shouldn't:
+!!constructor.static.matchFunction
// Operator + should not stick to following expression
This is a false positive due to the tricky nature of
disallowRightStickedOperators and for that reason this rule
has been deprecated and scheduled for removal in jscs 2.0.0
Change-Id: Ib731f11b1184d0e9865104a065421446a78dbfec
---
M .jscsrc
M .jshintrc
2 files changed, 0 insertions(+), 17 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jscsrc b/.jscsrc
index eb2c768..bc49e03 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -44,22 +44,6 @@
"<="
],
"requireRightStickedOperators": ["!"],
- "disallowRightStickedOperators": [
- "?",
- "+",
- "/",
- "*",
- ":",
- "=",
- "==",
- "===",
- "!=",
- "!==",
- ">",
- ">=",
- "<",
- "<="
- ],
"requireLeftStickedOperators": [","],
"disallowSpaceAfterPrefixUnaryOperators": [
"++",
diff --git a/.jshintrc b/.jshintrc
index 40e5b98..7f73166 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -1,7 +1,6 @@
{
// Enforcing
"bitwise": true,
- "curly": true,
"eqeqeq": true,
"freeze": true,
"latedef": true,
--
To view, visit https://gerrit.wikimedia.org/r/133271
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib731f11b1184d0e9865104a065421446a78dbfec
Gerrit-PatchSet: 2
Gerrit-Project: oojs/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
