Pgehres has submitted this change and it was merged. Change subject: Maintenance for ContributionTracking extension. ......................................................................
Maintenance for ContributionTracking extension. * Sprinkle missing semi-colons over JS. * Remove commented out code. * Declare static variables. * Moved error checking more to top of method. * Remove unused globals. * Deglobalized. * Replace deprecated calls. * Update docs. * Remove superfluous newlines. * Add FIXMEs for duplicate array keys. * Remove unused local variables. * Remove unneeded ?> Change-Id: Ie98eeeea60b0cafeb6ffe71bbfc6df6c45ff867a --- M ApiContributionTracking.php M ContributionTracking.processor.php M ContributionTracking_Tester.php M ContributionTracking_body.php M modules/jquery.contributionTracking.js M tests/ContributionTrackingAPITest.php M tests/ContributionTrackingProcessorTest.php M tests/ContributionTrackingTest.php 8 files changed, 61 insertions(+), 74 deletions(-) Approvals: Pgehres: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/26550 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie98eeeea60b0cafeb6ffe71bbfc6df6c45ff867a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContributionTracking Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> Gerrit-Reviewer: Pgehres <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
